Hi,
thanks for the info, I'll have a look at this.
Regards Stefan
On 04.02.21 03:24, Tom Rini wrote:
This platform did not ever enable CONFIG_REVISION_TAG, so the code to set the board_rev environment variable was never enabled. This particular symbol is also only for use with the REVISION ATAG and this platform is new enough to have never supported an ATAG-based Linux Kernel.
Cc: Stefan Bosch stefan_b@posteo.net Signed-off-by: Tom Rini trini@konsulko.com
I'd be happy to see this patch replaced by one that enables what I think you meant to be doing and by default. Thanks!
board/friendlyarm/nanopi2/board.c | 13 ------------- 1 file changed, 13 deletions(-)
diff --git a/board/friendlyarm/nanopi2/board.c b/board/friendlyarm/nanopi2/board.c index 68980536abe9..6e546853b863 100644 --- a/board/friendlyarm/nanopi2/board.c +++ b/board/friendlyarm/nanopi2/board.c @@ -294,16 +294,6 @@ static void set_ether_addr(void) env_set("ethaddr", ethaddr); }
-#ifdef CONFIG_REVISION_TAG -static void set_board_rev(void) -{
- char info[64] = {0, };
- snprintf(info, ARRAY_SIZE(info), "%02x", get_board_rev());
- env_set("board_rev", info);
-} -#endif
- static void set_dtb_name(void) { char info[64] = {0, };
@@ -435,9 +425,6 @@ int board_late_init(void) { bd_update_env();
-#ifdef CONFIG_REVISION_TAG
- set_board_rev();
-#endif set_dtb_name();
set_ether_addr();