On Mon 10 Aug 2009 16:55, Timur Tabi pondered:
On Mon, Aug 10, 2009 at 3:26 PM, Robin Getzrgetz@blackfin.uclinux.org wrote:
--- a/net/tftp.c +++ b/net/tftp.c @@ -22,6 +22,16 @@ /* (for checking the image size) */ #define HASHES_PER_LINE 65 /* Number of "loading" hashes per line */
+#ifdef CONFIG_TFTP_QUIET +#define puts_quiet(fmt) +#else +#define puts_quiet(fmt) puts(fmt); +#endif
This looks backwards to me. I would do this:
#ifdef CONFIG_TFTP_QUIET #define puts(x) puts_quiet(x) #endif
That way, you don't need to change all of the puts calls to puts_quiet. Plus, having the normal calls be "puts_quiet" that changes to puts when QUIET is *not* enabled just feels wrong.
There are other puts that you don't want quiet...
puts ("Starting again\n\n"); puts ("\nRetry count exceeded; starting again\n");
Otherwise - if you have a bad network - it will never output anything...