Tidy up the various pylint warnings in module 'main'.
Signed-off-by: Simon Glass sjg@chromium.org ---
tools/buildman/main.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/tools/buildman/main.py b/tools/buildman/main.py index a2ffbc9073e7..ca1beb098292 100755 --- a/tools/buildman/main.py +++ b/tools/buildman/main.py @@ -6,29 +6,21 @@
"""See README for more information"""
-import doctest -import multiprocessing import os -import re import sys
# Bring in the patman libraries +# pylint: disable=C0413 our_path = os.path.dirname(os.path.realpath(__file__)) sys.path.insert(1, os.path.join(our_path, '..'))
# Our modules -from buildman import board from buildman import bsettings -from buildman import builder from buildman import cmdline from buildman import control -from buildman import toolchain -from patman import patchstream -from patman import gitutil -from u_boot_pylib import terminal from u_boot_pylib import test_util
-def RunTests(skip_net_tests, verbose, args): +def run_tests(skip_net_tests, verbose, args): """Run the buildman tests
Args: @@ -36,9 +28,11 @@ def RunTests(skip_net_tests, verbose, args): verbosity (int): Verbosity level to use (0-4) args (list of str): List of tests to run, empty to run all """ + # These imports are here since tests are not available when buildman is + # installed as a Python module + # pylint: disable=C0415 from buildman import func_test from buildman import test - import doctest
test_name = args and args[0] or None if skip_net_tests: @@ -54,6 +48,11 @@ def RunTests(skip_net_tests, verbose, args): return (0 if result.wasSuccessful() else 1)
def run_buildman(): + """Run bulidman + + This is the main program. It collects arguments and runs either the tests or + the control module. + """ options, args = cmdline.ParseArgs()
if not options.debug: @@ -61,7 +60,7 @@ def run_buildman():
# Run our meagre tests if cmdline.HAS_TESTS and options.test: - RunTests(options.skip_net_tests, options.verbose, args) + run_tests(options.skip_net_tests, options.verbose, args)
# Build selected commits for selected boards else: