Hi Jagan,
On Wed, 8 Jan 2014 22:57:10 +0530, Jagan Teki jagannadh.teki@gmail.com wrote:
Hi Albert,
On Wed, Jan 8, 2014 at 10:44 PM, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi Jagannadha,
On Wed, 8 Jan 2014 15:53:07 +0530, Jagannadha Sutradharudu Teki jagannadha.sutradharudu-teki@xilinx.com wrote:
These changes are from u-boot-xlnx.git repo from git.xilinx.com and in addition of basic fdt support. This repo is well tested on xilinx zynq platform, hence pushing the same on upstream.
Excluded qspi and nand changes from previous series.
Please note that all this series available in u-boot-spi.git/master-xlnx repo.
-- Thanks, Jagan.
Changes for v4: - rebase to master - Removed CONFIG_SYS_NO_FLASH in zynq-common.h
As the series was rebased tu u-boot/master, not u-boot-arm/master, all patches adding board support failed to apply properly due to boards.cfg differences.
Yes - I saw this i'll rebase your u-boot-arm/master then.
I did resolve these manually, but at build-test time, all Zynq boards failed with "Makefile:11: *** Please define CONFIG_DEFAULT_DEVICE_TREE in your board header file. Stop." -- and were the only ones to do so.
Actually build will successful when you give the dts at runtime while building u-boot like Linux style. $ make DEVICE_TREE=<dts_file_name> ex: make DEVICE_TREE=zynq-zc702
This is the reason I am not defining this on individual pre-board configs. I guess this could be fine, please comment.
Boards in U-Boot are expected to build with commands
make <board>_config make
or with
./MAKEALL <board>
I am therefore not fine with a board which fails when built as above.
Instead of explicitly specifying a DT in the build command line, just make this DT the default one, by following the advice in the error message above, and putting it in the config header files. Each board can (and will, I assume) have its own default DT.
This way, building the board by default will wok, an you will still be able to override the default DT by specifying a different one on the command line if you so wish or need.
Amicalement,