On Fri, Apr 27, 2018 at 1:20 PM, Alex Kiernan alex.kiernan@gmail.com wrote:
On Fri, Apr 27, 2018 at 9:04 AM, Lukasz Majewski lukma@denx.de wrote:
Hi Kever,
Hi Jocelyn and Alex,
It's great to see you are getting this feature from google codeto be mainline code.
My opinion is that we should have the same fastboot cmd handlingin both UDP and USB in a common file, but not have separate code in net/fastboot.c and drivers/usb/gadget/f_fastboot.c, could you try to merge these two in one?
I've already proposed to put common code (the protocol handling) into /drivers/fastboot and have only small glue code for USB and NET.
I'm working towards that. I'm starting with the command implementations, then I'll look at the protocol.
Hopefully I'll get an RFCv2 out sometime over the weekend with the first bits done.
Just posted a v2, still needs more work, but getting feedback on the direction would be useful.