5 Jul
2021
5 Jul
'21
5:29 p.m.
On Mon, 5 Jul 2021 at 02:49, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
SMBIOS entries for manufacturer and board can't be empty, as the spec explicitly requires a value. Instead of passing "Unknown" and "Unknown product" for the manufacturer and product name if the .dts options are missing, try to use CONFIG_SYS_VENDOR and CONFIG_SYS_BOARD respectively. If those are not found either warn the user at runtime and use "Unknown" for both entries.
Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org
lib/smbios.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
I'm not quite sure what this is based on, but perhaps the code changed without me noticing.
How about adding some tests for this code?