On Wednesday, April 09, 2014 at 11:03:02 PM, Adrian Cox wrote:
Add endian support macros to interrupt transfers in the EHCI driver, to allow operation on PowerPC.
Signed-off-by: Adrian Cox adrian@humboldt.co.uk
Other than style issues, which need to be fixes (you can check for them with ./scripts/checkpatch.pl /path/to/your/0001-patch.patch) :
WARNING: line over 80 characters #103: FILE: drivers/usb/host/ehci-hcd.c:1193: + qh->qh_endpt1 = cpu_to_hc32((0 << 28) | /* No NAK reload (ehci 4.9) */
WARNING: line over 80 characters #141: FILE: drivers/usb/host/ehci-hcd.c:1217: + td->qt_buffer[0] = cpu_to_hc32((uint32_t)buffer + i * elementsize);
WARNING: line over 80 characters #142: FILE: drivers/usb/host/ehci-hcd.c:1218: + td->qt_buffer[1] = cpu_to_hc32((td->qt_buffer[0] + 0x1000) & ~0xfff);
WARNING: line over 80 characters #143: FILE: drivers/usb/host/ehci-hcd.c:1219: + td->qt_buffer[2] = cpu_to_hc32((td->qt_buffer[0] + 0x2000) & ~0xfff);
WARNING: line over 80 characters #144: FILE: drivers/usb/host/ehci-hcd.c:1220: + td->qt_buffer[3] = cpu_to_hc32((td->qt_buffer[0] + 0x3000) & ~0xfff);
WARNING: line over 80 characters #145: FILE: drivers/usb/host/ehci-hcd.c:1221: + td->qt_buffer[4] = cpu_to_hc32((td->qt_buffer[0] + 0x4000) & ~0xfff);
total: 0 errors, 6 warnings, 0 checks, 102 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE
Reviewed-by: Marek Vasut marex@denx.de
Also, use:
$ git format-patch HEAD~1 -o /path/to/your/patch $ git send-email --annotate --to=u-boot..... /path/to/your/patch/00*.patch
Best regards, Marek Vasut