Hi Stefan,
On Tue, Aug 8, 2017 at 6:37 PM, Stefan Roese sr@denx.de wrote:
Hi Bin,
On 08.08.2017 12:29, Bin Meng wrote:
On Tue, Aug 8, 2017 at 6:06 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese sr@denx.de wrote:
This patch adds the infrastructure to define different config headers with different configurations and default environment for the baseboards that can now be selected via Kconfig. The new configuration for the theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig file for this new target is added.
Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
v5:
- Added imply for some SPI NOR chips to the board Kconfig file
v4:
- Remove Gigadevice and Macronix flash support
v3:
- Rebased on latest master
- Removed unused macros from config headers
v2:
Added Bin's reviewed-by
board/congatec/Kconfig | 11 +++++ board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + configs/theadorable-x86-conga-qa3-e3845_defconfig | 54
++++++++++++++++++++++ include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++++++++++++++ 5 files changed, 109 insertions(+), 5 deletions(-) create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h
Reviewed-by: Bin Meng bmeng.cn@gmail.com
For some reason, this patch fails in buildman testing:
02: x86: conga: Add option to select different config headers for baseboards -make[2]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 1 -make[1]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 2 +../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token
- static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void
*)WAKEUP_BASE;
^- acpi_do_wakeup(vector);
- ^
+make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 +make[1]: *** [arch/x86/lib] Error 2 w+../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w+../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration]
But this failure disappears in patch [05/06]:
05: x86: conga: theadorable-x86-conga-qa3-e3845_defconfig: Misc defconfig updates x86: theadorable-x86-conga-qa3-e3845 -../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token
- static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void
*)WAKEUP_BASE;
^- acpi_do_wakeup(vector);
- ^
-make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 -make[1]: *** [arch/x86/lib] Error 2 w-../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w-../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration]
Could you please have a look at this? Thanks!
I've seen this issue as well and am unable to tell, why this fails in this configuration and in others not.
With patch 5/6 applied, the problem is gone though. Do you have an idea, where this issue might come from?
A patch was just sent out. Please check http://patchwork.ozlabs.org/patch/799115/
Regards, Bin