Re: [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board

Dear Stephen,

In message 4FBBBBCC.5020309@wwwdotorg.org you wrote:

...

...

+echo "#define ARCH "${arch}"" >> config.h +echo "#define CPU "${cpu}"" >> config.h +echo "#define BOARD "${board}"" >> config.h

Sorry, but names like ARCH and CPU are _way_ too intrusive and likely to clash. Please use something like CONFIG_SYS_ARCH_NAME etc. instead.

OK. Are you OK with the environment variable names? They're also common names like arch, cpu, board, vendor, soc.

We don;t have any rules yet for environment variable names, or name spaces or the like, so I see no problems here.

Best regards,

Wolfgang Denk