Dear Prafulla Wadaskar,
In message 1247967958-4446-1-git-send-email-prafulla@marvell.com you wrote:
hdr_size variable is initialized at the start of image creation algorithm instead of reading it each time. This facilitate to use the common code for other image type implementations for ex. kwbimage
Hm... I have no idea what you are trying to do, or why. You are aware that image_get_header_size() is a static inline, returning just "sizeof (image_header_t)"?
As far as the context of mkimage goes, you could as well consider it a constant.
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
tools/mkimage.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/tools/mkimage.c b/tools/mkimage.c index 967fe9a..c5b593c 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -250,9 +250,10 @@ NXTARG: ; * * write dummy header, to be fixed later */
- memset (hdr, 0, image_get_header_size ());
- if (write(ifd, hdr, image_get_header_size ()) != image_get_header_size ()) {
- int hdr_size;
We don't allow variable declarations in the middle of the code.
Best regards,
Wolfgang Denk