Hi Wolfgang,
On Thursday 14 May 2009 15:37:15 Wolfgang Denk wrote:
This patch adds an option to skip the video initialization on the ct6900. This is needed for the CPCI750 which can be built as CPCI host and adapter/target board. And the adapter board can't access the video cards.
Hm... why do you change the code of the viseo driver then? This change should be local to the CPCI750 board only.
I would love to do it this way. It's not possible though. At least I don't see such a solution.
+/*
- Implement a weak default function for boards that optionally
- need to skip the video initialization.
- */
+int __board_video_skip(void) +{
- return 0;
+} +int board_video_skip(void) __attribute__((weak, alias("__board_video_skip"))); +
/************************************************************************
- Init video chip
@@ -982,8 +992,12 @@ video_hw_init (void) struct ctfb_res_modes *res_mode; struct ctfb_res_modes var_mode; struct ctfb_chips_properties *chips_param;
- /* Search for video chip */
- /* Check if video initialization should be skipped */
- if (board_video_skip())
return NULL;This makes no sense to me. Instead of adding a (basicly board specific, even if you hide it with the weak implementation) shortcut to video_hw_init() you should not initialize the video driver on this board at all, leaving the video driver code unchanged.
Then please let me know how this can be accomplished. The CPCI750 uses the same U-Boot image both for the video-enabled CPCI-host version and for the video-disabled CPCI-adapter version. The video driver is not called from within the CPCI750 board files. It's called from drivers/video/cfb_console.c.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================