Re: [U-Boot] [PATCH 07/24] mxc_i2c: combine i2c_imx_bus_busy and i2c_imx_trx_complete into wait_for_sr_state

22 Jun 2012


      On 6/22/2012 10:34 AM, Troy Kisky wrote:
...
On 6/22/2012 10:01 AM, Marek Vasut wrote:
...
Dear Troy Kisky,
...
Not using udelay gives a more accurate timeout. The current 
implementation
of udelay in imx-common does not seem to wait at all for a udelay(1).
Add WATCHDOG_RESET() please.
Are you sure it is needed for a 0.1 second max delay?
Hmm, I agree. Retries could increase the delay.
...
...
...
Signed-off-by: Troy Kisky troy.kisky@boundarydevices.com
Best regards,
Marek Vasut
Thanks for the reviews Marek.
Troy