Hello Vivek,
2009/3/6 Vivek Kutal vivek.kutal@azingo.com:
Hi Remy, There are around ~70 warnings generated for pxa-regs.h for having more than 80 chars in a line, I have taken all the macro definitions from the linux kernel source code should I fix those warnings too ? Also pxa-regs.h already has many line with more than 80 chars.
Thanks for asking. If you look here: http://www.denx.de/wiki/U-Boot/CodingStyle, you will see that source files originating from different projects (for example the MTD subsystem or the hush shell code from the BusyBox project) may, after careful consideration, be exempted from these rules. For such files, the original coding style may be kept to ease subsequent migration to newer versions of those sources. Maybe you should also read this: http://www.denx.de/wiki/U-Boot/Patches
Kind regards,
Remy