Re: [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it

On 6/9/20 10:53 AM, Hayes Wang wrote:

Some settings of PHY have to work after resetting PHY.

Signed-off-by: Hayes Wang hayeswang@realtek.com

drivers/usb/eth/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c index dbb1721882..d774a0fa63 100644 --- a/drivers/usb/eth/r8152.c +++ b/drivers/usb/eth/r8152.c @@ -947,7 +947,7 @@ static int rtl8152_set_speed(struct r8152 *tp, u8 autoneg, u16 speed, u8 duplex) return -EINVAL; }

• bmcr = BMCR_ANENABLE | BMCR_ANRESTART;
  

• bmcr = BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET;
  

Do you really need to reset a PHY while resetting the autonegotiation ? I think if you reset the PHY , then the ANEG operation is restarted by default or undefined, no ?