Re: [U-Boot] [PATCH v3 001/108] binman: Correct symbol calculation with non-zero image base

On Mon, Oct 21, 2019 at 11:33 AM Simon Glass sjg@chromium.org wrote:

At present binman adds the image base address to the symbol value before it writes it to the binary. This is not correct since the symbol value itself (e.g. image position) has no relationship to the image base.

Fix this and update the tests to cover this case.

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v3: None Changes in v2: None

tools/binman/elf.py | 4 +--- tools/binman/test/u_boot_binman_syms.lds | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com