-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/25/2013 11:08 AM, Adnan Ali wrote:
On 25/02/13 15:04, Tom Rini wrote:
On Mon, Feb 25, 2013 at 12:24:37PM +0000, Adnan Ali wrote:
Introduces btrfs file-system to read file from volume/sub-volumes with btrload command. This implementation has read-only support. This btrfs implementation is based on syslinux btrfs code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
Signed-off-by: Adnan Ali adnan.ali@codethink.co.uk
A few things: - In general in fs/btrfs/btrfs.c I see some coding style problems (lack of spacing, non-printf's longer than 80-wide). Do these come from syslinux and thus will make any re-syncs easier?
Most of the ported code is unmodified so its coding style should be same as syslinux.
That's what I thought.
- It looks like you added support for CONFIG_CMD_FS_GENERIC, if
so did you test that?
This command wasn't enabled in my configs. I haven't added any command i.e btrls for this as this feature is not supported yet.
Can you then please? Thanks.
- Can you please enable this support code on at least one
platform, preferably the one you've tested and developed with?
Even if do enable support for this, it will also debug 'Unsupported filesystem type.'
I don't understand.
For the rest of changes you proposed i will change them and send as v4 patch.
Thanks!
- -- Tom