16 Sep
2010
16 Sep
'10
11:29 p.m.
Dear Timur Tabi,
In message 4C928998.4040805@freescale.com you wrote:
+/**
- set_mux_to_lbc - disable the DIU so that we can read/write to elbc
Incorrect multiline comment format. Please check and fix globally.
Can you be more specific? Is it the "**"?
Yes.
"#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS" / "#endif" arount the #undef ?
Why? CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS is only defined if CONFIG_VIDEO is defined. It's just one block of macros.
OK, if you like it that way. OTOH, the #ifdef would not hurt and keep the logic in place in case you ever define CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS for other reasons as well.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"...and the fully armed nuclear warheads, are, of course, merely a
courtesy detail."