Re: [PATCH] include: phy: fix NULL pointer check in phy_write()

On 18. 08. 20 2:31, Thirupathaiah Annapureddy wrote:

phy_write() uses bus->write() instead of bus->read(). This means NULL pointer pre-check needs to happen on bus->write instead of bus->read.

Signed-off-by: Thirupathaiah Annapureddy thiruan@linux.microsoft.com

include/phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/phy.h b/include/phy.h index 1dbbf65111..cbdb10d6fc 100644 --- a/include/phy.h +++ b/include/phy.h @@ -205,7 +205,7 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum, { struct mii_dev *bus = phydev->bus;

• if (!bus || !bus->read) {

• if (!bus || !bus->write) { debug("%s: No bus configured\n", __func__); return -1; }

Reviewed-by: Michal Simek michal.simek@xilinx.com

Thanks, Michal