On Thu, 16 Oct 2008 13:49:42 -0400 richardretanubun richardretanubun@ruggedcom.com wrote:
Hi Richard,
Removed #ifdef CONFIG_MPC834X dependency on upmconfig function.
please elaborate your commit messages to include /why/ this change is needed, not only what it does (in this particular case we can easily see what it does). Adding material from your prior mail will achieve most of this.
Signed-off-by: Richard Retanubun RichardRetanubun@RugggedCom.com
I'm guessing s/ggg/gg/? I've seen this before; please edit your git configuration/environment to fix this once and for all (it conflicts with the commit's author (From:) and comes into play whenever commit statistics are generated).
/* Set the OP field in the MxMR to "normal" and the MAD field to000000 */
biggest problem is it looks like this is line wrapped anyway:
Applying: Removed #ifdef CONFIG_MPC834X dependency on upmconfig function fatal: corrupt patch at line 20
other than that, looks good ;)
Thanks,
Kim