Dear Fabio Estevam,
In message 1369157542-25734-1-git-send-email-fabio.estevam@freescale.com you wrote:
When the SDHC port number index is invalid we should return an error code immediately.
Currently we return 'status', which has a value of zero, causing board_mmc_init() to incorrectly return sucess.
Fix this by returning -EINVAL instead.
Can we _please_ remove all this code? A _runtime_ check for a _build_ _time_ _detectable_ situation makes no sense to me.
For such a misconfiguration, the build should fail.
Handling this at runtime is the wrong approach.
This comment applies for the whole series.
Actually - are you not surprised that you have to fix the same issue for all boards? This is a clear indication of duplicated code that needs to be factored out.
Best regards,
Wolfgang Denk