On Mon, 15 May 2023 11:17:14 -0300 Fabio Estevam festevam@gmail.com wrote:
Hi Fabio,
On Mon, May 15, 2023 at 10:52 AM Andre Przywara andre.przywara@arm.com wrote:
It seems like the header inclusion guard for some Freescale crosspoint switch header was misspelled.
Make the preprocessor symbol for the #ifndef and #define lines the same, so that the double inclusion protection works as expected.
Signed-off-by: Andre Przywara andre.przywara@arm.com
board/freescale/common/vsc3316_3308.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/common/vsc3316_3308.h b/board/freescale/common/vsc3316_3308.h index 49a684f9f49..8d343ba4d65 100644 --- a/board/freescale/common/vsc3316_3308.h +++ b/board/freescale/common/vsc3316_3308.h @@ -4,7 +4,7 @@ */
#ifndef __VSC_CROSSBAR_H_ -#define __VSC_CROSSBAR_H 1_ +#define __VSC_CROSSBAR_H_
The change is correct, but it does not match the Subject/commit log.
What do you mean, exactly? To put *some* context into the commit message, I tried to find out what this "vsc" device is about, and found "crosspoint switch" somewhere (doc/README.VSC3316-3308). Is that not what it is about? Or is not a Freescale device, but just used by Freescale SoCs? Some T208 hardware seems to be the only user, though.
Can you suggest a better description?
Cheers, Andre