On Fri, May 12, 2017 at 04:10:07PM +0200, Marek Behún wrote:
This watchdog can be found on some Armada chips.
Signed-off-by: Marek Behun marek.behun@nic.cz
drivers/watchdog/Kconfig | 7 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/orion_wdt.c | 128 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 136 insertions(+) create mode 100644 drivers/watchdog/orion_wdt.c
In a few places you're adding 2 newlines instead of one, please fix. Also: [snip]
+config ORION_WATCHDOG
- bool "Enable "
- select HW_WATCHDOG
You need to finish the "Enable" line, and most likely add a depends on ... as well, unless you can also enable and build it for sandbox (which would be great, that's where we get our static analysis done).
- This file is licensed under the terms of the GNU General Public
- License version 2. This program is licensed "as is" without any
- warranty of any kind, whether express or implied.
SPDX tag please.
For the rest of it, please make it use the watchdog uclass and so forth, thanks!