On 05/13/2013 05:17:40 AM, Zhang Ying-B40530 wrote:
diff --git a/spl/Makefile b/spl/Makefile index b5a8de7..3a3b868 100644 --- a/spl/Makefile +++ b/spl/Makefile @@ -51,6 +51,9 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o endif ifeq ($(CPU),mpc85xx) LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o +ifdef CONFIG_SPL_INIT_DDR_SUPPORT +LIBS-y += arch/powerpc/cpu/mpc8xxx/ddr/libddr.o +endif
Why isn't this handled as part of lib8xxx.o? We should avoid putting hardware-specific things in generic Makefiles. There ones that are already there should be fixed at some point. [Zhang Ying] Do you mean that all things of the directory " arch/powerpc/cpu/mpc8xxx/ddr " will be moved to the directory "arch/powerpc/cpu/mpc8xxx/"?
No. I meant that arch/powerpc/cpu/mpc8xxx/Makefile should contain the LIBS addition for the subdirectory, but apparently it doesn't work that way even in non-SPL. So ignore this; it's more of a future makefile cleanup issue.
-Scott