Dear Dave Mitchell,
In message 1260821359-8705-1-git-send-email-dmitchell@appliedmicro.com you wrote:
Current de-assert reset is not sufficient for the USB PHY reset on some Canyonlands platforms. The patch adds an assert/de-assert sequence. This addresses a USB detection problem for devices attached prior to power-up. The delay lengths are needed for power to the PHY to stabilize.
Hm...
- /* Enable USB host & USB-OTG */
- /* Enable USB host & USB-OTG;force assert,then de-assert PHY reset */
- out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 1);
- mdelay(100); out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 0);
- mdealy(100);
It would have been nice if you had at least tried to compile that. "mdealy()" is a typo, right?
And do we really need 200 milliseconds delay?
Some customers who care about boot times will not be happy about such an aditional delay. You add this code do board_early_init_f() which always gets executed. But actually this is only needed when we want to use the USB port in U-Boot, right? So this should be added to the USB init code, and not to the common code.
Best regards,
Wolfgang Denk