-----Original Message----- From: Fabio Estevam [mailto:festevam@gmail.com] Sent: Tuesday, December 27, 2016 9:11 AM To: Peng Fan peng.fan@nxp.com Cc: Stefano Babic sbabic@denx.de; U-Boot-Denx u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 17/18] imx: imx7ulp: add EVK board support
On Mon, Dec 26, 2016 at 11:07 PM, Peng Fan peng.fan@nxp.com wrote:
What does "POR-6" mean?
POR means power on reset, 6 is the value of register system reset status.
Please remove the '6' as it is confusing and we do not print such information on other i.MX SoCs.
Fix in V2.
+static int mx7ulp_board_rev(void) +{
return 0x41;+}
What does hardcoded number mean?
We do not have chip id or board id, so we just use a dummy number here.
Do we really need this? Please put a document explaining this or simply remove this function.
I'll take care of it to see whether we could remove it.
Thanks, Peng.