On Wed, Feb 14, 2018 at 08:15:15PM +0530, Faiz Abbas wrote:
Hi,
On Wednesday 14 February 2018 08:04 PM, Tom Rini wrote:
On Wed, Feb 14, 2018 at 07:59:46PM +0530, Faiz Abbas wrote:
Since 82b9dc63 ("Only build cli_readline.o for CMDLINE on non-SPL"), cli_simple.c is only being built for non-SPL case. However, dfu_mmc requires cli_simple.c to build and dfu fails to build for SPL when CONFIG_HUSH_PARSER is disabled.
Therefore, limit dfu_mmc to non-SPL case only.
Signed-off-by: Faiz Abbas faiz_abbas@ti.com
drivers/dfu/Makefile | 2 ++ drivers/dfu/dfu.c | 2 ++ 2 files changed, 4 insertions(+)
Does DFU for MMC make sense inside of SPL?
No.
If so, you should follow
82b9dc63 and CONFIG_FSL_DDR_INTERACTIVE and bring back in cli_simple.o (and cli_readline.o, if needed) for CONFIG_SPL_DFU_MMC or so. If not, we should more cleanly and clearly block out all non-DFU RAM cases for SPL. Thanks!
Do you mean non-RAM DFU cases? Block out everything but RAM?
Based on looking at what's in Kconfig at least, yes, only SPL+DFU RAM is what's possible now. So we should make the code more clearly show that. Thanks!