Re: [U-Boot-Users] [PATCH] ML507: New board support

In message 1215778964-6771-1-git-send-email-ricardo.ribalda@uam.es you wrote:

-Suport for the Xilinx ML507 Development Board

There are some coding stylke issues: trailing white space, aliglnment not by TAB, etc.

+++ b/board/xilinx/ml507/init.S @@ -0,0 +1,45 @@ +/*

• (C) Copyright 2008
• Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribalda<at>uam.es , ricardo.ribalda<at>gmail.com

Line too long.

+int checkboard(void) +{

• printf

•    ("ML507 Board ported by Ricardo Ribalda ricardo.ribalda@uam.es (http://qtec.com) \n");
  

Line too long. And please print only SHORT messages!

+phys_size_t initdram(int board_type) +{

• return 256 * 1024 * 1024;

Please use memsize() to autodetect the size of your RAM instead of hard-wiring it.

+int testdram(void) +{

• printf("test: xxx MB - ok\n");
• return (0);

+}

Please remove.

new file mode 100644 index 0000000..054661c --- /dev/null +++ b/board/xilinx/ml507/u-boot.lds @@ -0,0 +1,149 @@ +/*

• • (C) Copyright 2000
• • Wolfgang Denk, DENX Software Engineering, wd@denx.de.
• • Modified by: Ricardo Ribalda Delgado ricardo.ribalda<at>gmail.com ricardo.ribalda<at>uam.es

Line too long.

Best regards,

Wolfgang Denk