wd@denx.de wrote on Monday, July 30, 2007 5:42 PM:
In message 20070724085839.20151.56293.stgit@tq-sewsrv-4.tq-net.de you wrote:
#define CFG_FLASH_BASE 0x40000000 -#define CFG_MONITOR_LEN (256 << 10) /* Reserve 256 kB for Monitor */ +#define CFG_MONITOR_LEN (256 << 10) /* Reserve 256 kB for Monitor */ #define CFG_MONITOR_BASE CFG_FLASH_BASE -#define CFG_MALLOC_LEN (128 << 10) /* Reserve 128 kB for malloc() */ +#define CFG_MALLOC_LEN (256 << 10) /* Reserve 128 kB for malloc() */
Why do you destroy the nice alignement of the closing comments? Don't do that.
Oh, on my editor this lines looked rather odd, because they exceeded 80 columns and my editor brakes it into two lines.
-239,9 +244,9 @@ #define CFG_FLASH_WRITE_TOUT 500 /* Timeout for Flash Write (in ms) */
#define CFG_ENV_IS_IN_FLASH 1 -#define CFG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */ -#define CFG_ENV_SIZE 0x08000 /* Total Size of Environment Sector */ -#define CFG_ENV_SECT_SIZE 0x20000 /* Total Size of Environment Sector */ +#define CFG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */ +#define CFG_ENV_SIZE 0x08000 /* Total Size of Environment */ +#define CFG_ENV_SECT_SIZE 0x40000 /* Total Size of Environment Sector */
Again, why such reformatting which makes things only worse?
Sorry for that! Doing this I had Linus CodingStyle in mind, which states "The limit on the length of lines is 80 columns and this is a hard limit". I reduced the line length in the believe of making it more coding style conform. It seems I achieved the contrary :(
Is it OK for comment lines to exceed 80 columns in general? I'm quite often not sure, where to place comments correctly: At the end of a coded line, although the 80 column limit is exceeded? Or better in the line before? Or at the end of the coded line, but with the comment splittet to several lines to not exceed 80 collums:
#define CFG_ENV_SECT_SIZE 0x40000 /* Total Size of Environment Sector */
Best Regards,
Martin Krause
-- TQ-Systems GmbH Muehlstrasse 2, Gut Delling, D-82229 Seefeld Amtsgericht Muenchen, HRB 105 018, UST-IdNr. DE 811 607 913 Geschaeftsfuehrer: Dipl.-Ing. (FH) Detlef Schneider, Dipl.-Ing. (FH) Ruediger Stahl http://www.tq-group.com