-----Original Message----- From: Stefano Babic [mailto:sbabic@denx.de] Sent: Thursday, May 18, 2017 4:20 PM To: Peng Fan peng.fan@nxp.com; Fabio Estevam festevam@gmail.com Cc: Stefano Babic sbabic@denx.de; U-Boot-Denx u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2 12/12] imx: mx7dsabresd: add board revision check
Hi Peng,
Hi Stefano,
On 18/04/2017 02:54, Peng Fan wrote:
Hi Fabio,
-----Original Message----- From: Fabio Estevam [mailto:festevam@gmail.com] Sent: Monday, April 17, 2017 11:00 PM To: Peng Fan peng.fan@nxp.com Cc: Stefano Babic sbabic@denx.de; U-Boot-Denx u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2 12/12] imx: mx7dsabresd: add board revision check
On Thu, Apr 13, 2017 at 3:10 AM, Peng Fan peng.fan@nxp.com wrote:
+#define BOARD_REV_C 0x300 +#define BOARD_REV_B 0x200 +#define BOARD_REV_A 0x100
+static int mx7sabre_rev(void) +{
/** Get Board ID information from OCOTP_GP1[15:8]* i.MX7D SDB RevA: 0x41* i.MX7D SDB RevB: 0x42Isn't this versioning scheme shared with other NXP boards? If so, it would be better to put this in common code.
I prefer to keep the code here. There are board revision fuse for the boards from NXP, but this is not always true, I think.
Patches 1..11 are free of comments. I am merging them and I will send PR to Tom for inclusion after my build test. I will just let this last one out.
It is ok for me to let this out. Thanks.
Thanks, Peng.
Regards, Stefano
--
========= DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de ============================================================ =========