Hi Stefan
Thanks for all the help in solving the problem. I have some questions about submitting the patch and testing of the patch.
First of all I am working on proprietary board based on AMCC sequoia board. Hence some of the files I changed are module specific like config.mk in nand_spl/board/....and I also modified the following lines in u-boot-nand.lds
cpu/ppc4xx/start.o (.text)
/* Align to next NAND block */ . = ALIGN(0x20000); common/environment.o (.ppcenv) /* Keep some space here for redundant env and potential bad env blocks */ . = ALIGN(0x80000);
Above is to allow some space for u-boot environment and possible bad blocks. This file is also module specific.
Besides these two files I have changed nand_boot.c and ndfc.c. Considering all this, how should I create this patch. Should I create a patch for the sequoia board?
Also how are we going to test this patch? I'll make sure it meets all the requirement in terms of coding style, etc but as far as testing goes, I can only test on my board because sequoia reference board comes only with 256Mb NAND flash.
Thanks
Nikhil
On Feb 12, 2008 2:31 PM, Wolfgang Denk wd@denx.de wrote:
In message 200802120711.17212.sr@denx.de you wrote:
I got my idea from the current Linux MTD NAND drivers (and U-Boot btw). Here the distinction between small page and large page devices is done this way:
...
That's why I still prefer my suggestion.
Ok, thanks for checking.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The people of Gideon have always believed that life is sacred. That the love of life is the greatest gift ... We are incapable of destroying or interfering with the creation of that which we love so deeply -- life in every form from fetus to developed being. -- Hodin of Gideon, "The Mark of Gideon", stardate 5423.4