
5 Oct
2013
5 Oct
'13
9:49 p.m.
Dear Simon,
with commit a8f6ab5 "fs: Add support for saving data to filesystems" you add the function do_save() to U-Boot. This includes the following code (line numbers as of current master):
"fs/fs.c":
... 331 filename = argv[3]; 332 addr = simple_strtoul(argv[4], NULL, cmdline_base); 333 bytes = simple_strtoul(argv[5], NULL, cmdline_base); 334 if (argc >= 7) 335 pos = simple_strtoul(argv[6], NULL, cmdline_base); 336 else 337 pos = 0;
Should we not perform at least minimal error checking, i. e. verify that no garbage arguments have been passed to that function?
Best regards, Viele Grüße,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The easiest way to figure the cost of living is to take your income
and add ten percent.