Hi Luca,
Hi, here's the tftpsrv patch series, with checkpatch warnings fixed. Only patches 2 and 3 are actually changed. Patch 1 is unchanged and patches 4-6 have been simply rebased.
There are still a few checkpatch issues (!), though, that I think can be ignored and I'm not going to fix unless there's a specific request.
Here they are:
WARNING: consider using kstrto* in preference to simple_strtol #125: FILE: net/tftp.c:619:
TftpRemotePort = simple_strtol(ep, NULL, 10);Which is Linux-only
WARNING: do not add new typedefs #61: FILE: include/net.h:367: +typedef enum { BOOTP, RARP, ARP, TFTP, DHCP, PING, DNS, NFS, CDP, NETCONS, SNTP,
Is a typedef *enum* considered bad in U-Boot?
For new code yes. We (well at least I) much rather prefer to see what type a variable is without looking up the typedef for it.
Cheers Detlev