Hi Lukasz,
On 21 November 2017 at 18:19, Lukasz Majewski lukma@denx.de wrote:
On Mon, 20 Nov 2017 15:33:35 -0700 Simon Glass sjg@chromium.org wrote:
Add documentation for the log system.
Signed-off-by: Simon Glass sjg@chromium.org Reviewed-by: Bin Meng bmeng.cn@gmail.com
Changes in v3:
- Rebase to master
Changes in v2:
- Drop the special log() functions from the README
doc/README.log | 214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 214 insertions(+) create mode 100644 doc/README.log
[..]
+Code size +---------
+Code size impact depends largely on what is enabled. The following numbers are +for snow, which is a Thumb-2 board:
+This series: adds bss +20.0 data +4.0 rodata +4.0 text +44.0
It would be more informative to add units (KiB, B).
OK I will send a patch for that.
+CONFIG_LOG: bss -52.0 data +92.0 rodata -635.0 text +1048.0 +CONFIG_LOG_MAX_LEVEL=7: bss +188.0 data +4.0 rodata +49183.0 text +98124.0 + +The last option turns every debug() statement into a logging call, which +bloats the code hugely. The advantage is that it is then possible to enable +all logging within U-Boot.
[..]
As I said before - this is a great piece of SW.
Great, thanks!
Reviewed-by: Lukasz Majewski lukma@denx.de
Best regards,
Lukasz Majewski
Regards, Simon