Dear Masahiro,
In message 1397721632-18797-3-git-send-email-yamada.m@jp.panasonic.com you wrote:
Some functions in include/net.h are ported from include/linux/etherdevice.h of Linux Kernel.
For ex. is_zero_ether_addr() is_multicast_ether_addr() is_broadcast_ether_addr() is_valid_ether_addr();
So, we should use the same function name as Linux Kernel, eth_rand_addr(), for consistency.
Because eth_rand_addr() is impilemented as inline function, it should not be surrounded by ifdef CONFIG_RANDOM_MACADDR.
None of this is mentioned in the description of this patch series in your cover letter.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de It is common sense to take a method and try it. If it fails, admit it frankly and try another. But above all, try something. - Franklin D. Roosevelt