On Tue, 30 Jan 2024 at 19:35, Caleb Connolly caleb.connolly@linaro.org wrote:
Import the supporting pm8916.dtsi and msm8916-pm8916.dtsi files from upstream in preparation for switching boards over.
Taken from kernel tag v6.7
Reviewed-by: Neil Armstrong neil.armstrong@linaro.org Signed-off-by: Caleb Connolly caleb.connolly@linaro.org
arch/arm/dts/msm8916-pm8916.dtsi | 157 ++++++++++++++++++++++++++++++++++ arch/arm/dts/pm8916.dtsi | 178 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 335 insertions(+)
[snip]
diff --git a/arch/arm/dts/pm8916.dtsi b/arch/arm/dts/pm8916.dtsi new file mode 100644 index 000000000000..f4de86787743 --- /dev/null +++ b/arch/arm/dts/pm8916.dtsi @@ -0,0 +1,178 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <dt-bindings/iio/qcom,spmi-vadc.h> +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/spmi/spmi.h>
+&spmi_bus {
pm8916_0: pmic@0 {compatible = "qcom,pm8916", "qcom,spmi-pmic";reg = <0x0 SPMI_USID>;#address-cells = <1>;#size-cells = <0>;pon@800 {compatible = "qcom,pm8916-pon";reg = <0x800>;mode-bootloader = <0x2>;mode-recovery = <0x1>;pwrkey {compatible = "qcom,pm8941-pwrkey";interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;debounce = <15625>;bias-pull-up;linux,code = <KEY_POWER>;};pm8916_resin: resin {compatible = "qcom,pm8941-resin";interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;debounce = <15625>;bias-pull-up;status = "disabled";};watchdog {compatible = "qcom,pm8916-wdt";interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>;timeout-sec = <60>;};
watchdog button isn't supported by the U-Boot driver code. So it leads to spurious error as follows:
Unknown button node 'watchdog' should be 'pwrkey' or 'resin'
I suppose the button-qcom-pmic driver should gracefully handle the unsupported case.
-Sumit