
26 Apr
2019
26 Apr
'19
7:58 p.m.
On 4/26/19 2:16 PM, Eugeniu Rosca wrote:
On Mon, Apr 22, 2019 at 12:20 AM Marek Vasut marek.vasut@gmail.com wrote:
[..]
- @gpio_request_enable: requests and enables GPIO on a certain pin.
nit: the existing documentation follows an imperative mood
[..]
* gpio_request_enable: requests and enables GPIO on a certain pin.
[..]
* gpio_disable_free: free up GPIO muxing on a certain pin.
nit: the established pattern is: 'name() - description', while here I see 'name: description.'
Other than that: Reviewed-by: Eugeniu Rosca erosca@de.adit-jv.com Tested-by: Eugeniu Rosca erosca@de.adit-jv.com
Thanks!
I copied the documentation from Linux, so I'll keep it as-is.
--
Best regards,
Marek Vasut