Hi Engeniu,
-----Original Message----- From: Eugeniu Rosca [mailto:erosca@de.adit-jv.com] Sent: Wednesday, May 09, 2018 5:04 PM To: Tom Rini trini@konsulko.com; Yamada, Masahiro/山田 真弘 yamada.masahiro@socionext.com; Petr Vorel pvorel@suse.cz Cc: Ulf Magnusson ulfalizer@gmail.com; Simon Glass sjg@chromium.org; U-Boot Mailing List u-boot@lists.denx.de; Eugeniu Rosca erosca@de.adit-jv.com; Eugeniu Rosca rosca.eugeniu@gmail.com Subject: Re: [U-Boot] [PATCH] kconfig: Print reverse dependencies in groups
Masahiro, Tom, Petr,
Thanks for your prompt feedback.
On Wed, May 09, 2018 at 10:27:00AM +0900, Masahiro Yamada wrote:
I prefer syncing to check-picking. [...] Would you do that please? Or, do you want me to do it?
I would happily attempt that. However, see my below question.
On Tue, May 08, 2018 at 09:31:42PM -0400, Tom Rini wrote:
I'd greatly appreciate it if you can do a sync up to v4.17-rc4 or so.
Just to avoid any miscommunication, is my understanding correct that this is an explicit request for Masahiro to take care of the update? I would totally understand this.
FWIW, here is some statistics of the kernel kconfig development in the v4.10..v4.17-rc4 commit range:
- 86 non-merge change-sets:
git rev-list --no-merges --count v4.10..v4.17-rc4 -- scripts/kconfig/ 86
- 8 Kconfig commits which touch non-Kconfig files too (ignoring Documentation) and hence might require more delicate conflict resolution:
for c in $(git rev-list --reverse --no-merges v4.10..v4.17-rc4 -- scripts/kconfig/); do if (git log --full-diff --format="" --name-only -1 $c -- scripts/kconfig | egrep -v "scripts/kconfig|Documentation" > /dev/null); then git --no-pager log --oneline $c -1; fi; done
cb77f0d623ff scripts: Switch to more portable Perl shebang bb3290d91695 Remove gperf usage from toolchain b24413180f56 License cleanup: add SPDX GPL-2.0 license identifier to files with no license 07a422bb213a kbuild: restore autoksyms.h touch to the top Makefile 911a91c39cab kconfig: rename silentoldconfig to syncconfig 598893002745 .gitignore: move *.lex.c *.tab.[ch] patterns to the top-level .gitignore 9a8dfb394c04 kbuild: clean up *.lex.c and *.tab.[ch] patterns from top-level Makefile b23d1a241f4e kbuild: add %.lex.c and %.tab.[ch] to 'targets' automatically
I also think that the most sensitive part of this update is related to:
- changed tooling requirements for hosts, e.g. flex and bison seem to be required starting with commit 29c833061c1d ("kconfig: generate lexer and parser during build instead of shipping").
- dropped silentoldconfig support, starting with commit cedd55d49dee ("kconfig: Remove silentoldconfig from help and docs; fix kconfig/conf's help").
There might be questions from users experiencing build errors/warnings after the update, same as we've seen in [1].
[1] https://patchwork.kernel.org/patch/10318503/
I would appreciate if Tom answers the question raised in the beginning of my post.
Tom will make a decision.
Just my thought.
U-Boot is basically a mirror of Linux.
Syncing Kconfig will add new tool requirement, flex & bison, for building U-Boot, but this is OK because Linux does it.
U-Boot follows Linux, for example, recently U-Boot adopted Linux-like SPDX license tag style.
And, you understand well the points for resyncing. Yes, other parts must be adjusted.
So, I am happy if you contribute to this work.
Thanks!