Hi Tom,
On 9 November 2018 at 10:43, Tom Rini trini@konsulko.com wrote:
On Tue, Oct 02, 2018 at 05:22:42AM -0600, Simon Glass wrote:
It can confusing when U-Boot SPL hangs for no obvious reason, when it is unable to load U-Boot. Add a message to indicate the cause.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2: None
common/spl/spl.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/spl.c b/common/spl/spl.c index 396c42e1e1b..512141c4139 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -485,6 +485,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, return 0; } }
puts(SPL_TPL_PROMPT "No more boot devices\n"); return -ENODEV;}
Don't we have a similar debug() statement around this part of the boot flow? It is annoying but I also think we ended up dropping it due to binary size issues.
Er yes you are right:
puts(SPL_TPL_PROMPT "failed to boot from all boot devices\n");
I'll drop this patch.
Regards, Simon