Re: [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot

On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:

• volatile struct temac_reg *regs = priv->regs;
• regs->lsw = (phy_addr << 5) | reg_addr;
• regs->ctl = MIIMAI | (emac << 10);

you should still be going through read/write i/o helper funcs rather than relying on the volatile markings

the rest looks sane -mike