On 04/25/2019 05:33 PM, Michal Simek wrote:
On 17. 04. 19 19:46, Philip Balister wrote:
Signed-off-by: Philip Balister philip@opensdr.com
configs/zynq_minized_defconfig | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/configs/zynq_minized_defconfig b/configs/zynq_minized_defconfig index d61659f785..6c56b9b9b9 100644 --- a/configs/zynq_minized_defconfig +++ b/configs/zynq_minized_defconfig @@ -1,4 +1,5 @@ CONFIG_ARM=y +CONFIG_SYS_CONFIG_NAME="zynq_minized"
this is here because of 3/4
Yes. Should we be looking at cleaning up the default zynq environment?
CONFIG_ARCH_ZYNQ=y CONFIG_SYS_TEXT_BASE=0x4000000 CONFIG_SPL=y @@ -12,9 +13,9 @@ CONFIG_FIT_SIGNATURE=y CONFIG_FIT_VERBOSE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_OS_BOOT=y +CONFIG_SPL_SPI_LOAD=y CONFIG_SYS_PROMPT="Zynq> " -CONFIG_CMD_THOR_DOWNLOAD=y -CONFIG_CMD_DFU=y +# CONFIG_CMD_ELF is not set
What's the reason?
I'm not a DFU expert. The time I saw it used, the board needed to be a USB device. The minized only supports USB host. The micro usb connectors are for serial/jtag and an extra power supply.
As I recall DFU has a maximum payload size that is smaller then the available emmc. This can be really confusing to uncover.
# CONFIG_CMD_FLASH is not set CONFIG_CMD_FPGA_LOADBP=y CONFIG_CMD_FPGA_LOADFS=y @@ -25,15 +26,12 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set -CONFIG_CMD_TFTPPUT=y CONFIG_CMD_CACHE=y CONFIG_CMD_EXT4_WRITE=y CONFIG_DEFAULT_DEVICE_TREE="zynq-minized" CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_NET_RANDOM_ETHADDR=y +# CONFIG_NET is not set
If there is usb host you maybe need this for usb to ethernet convertors.
There is USB host. Do many people use usb ethernet convertors with u-boot?
CONFIG_SPL_DM_SEQ_ALIAS=y -CONFIG_DFU_MMC=y -CONFIG_DFU_RAM=y CONFIG_FPGA_XILINX=y CONFIG_FPGA_ZYNQPL=y CONFIG_DM_GPIO=y @@ -44,11 +42,6 @@ CONFIG_SF_DEFAULT_SPEED=30000000 CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y -CONFIG_PHY_MARVELL=y -CONFIG_PHY_REALTEK=y -CONFIG_PHY_XILINX=y -CONFIG_MII=y -CONFIG_ZYNQ_GEM=y
if there is no physical port we can remove this.
OK
CONFIG_DEBUG_UART_ZYNQ=y CONFIG_ZYNQ_SERIAL=y CONFIG_ZYNQ_QSPI=y @@ -63,3 +56,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_FUNCTION_THOR=y +CONFIG_REGEX=y
Don't have this board to say what it is reasonable. I see some usbs on pictures that's why maybe that DFU stuff can stay there too.
Please put it to description in v2.
Thanks for the review.
Philip
M