I'm reading/replying to these one-by-one for sanity/clarity with regards to BeagleBoard...
-----Original Message----- From: Tom Rini trini@ti.com Date: Thu, 22 Mar 2012 12:09:07 -0700 To: u-boot@lists.denx.de Subject: [U-Boot] [RFC v0 01/11] omap3+: Introduce <configs/omap3_common.h>
This is a common file for OMAP3 (and OMAP3-alike) platforms to have default, configurable when needed values and choices placed. All users of this file now have a section for providing their overrides (when the defaults are not wanted), this file, and then a place to opt-out of choices this file has made.
Signed-off-by: Tom Rini trini@ti.com
include/configs/am3517_crane.h | 19 +++++++++----- include/configs/am3517_evm.h | 20 ++++++++++----- include/configs/cm_t35.h | 22 +++++++++++------ include/configs/devkit8000.h | 24 ++++++++++++------ include/configs/dig297.h | 22 +++++++++++------ include/configs/igep00x0.h | 19 ++++++++------ include/configs/mcx.h | 24 +++++++++++-------- include/configs/mt_ventoux.h | 13 ++++++++++ include/configs/omap3_beagle.h | 19 +++++++++----- include/configs/omap3_common.h | 40 ++++++++++++++++++++++++++++++++ include/configs/omap3_evm.h | 3 -- include/configs/omap3_evm_common.h | 15 ++++++++--- include/configs/omap3_evm_quick_mmc.h | 7 +++-- include/configs/omap3_evm_quick_nand.h | 7 +++-- include/configs/omap3_logic.h | 20 ++++++++++----- include/configs/omap3_mvblx.h | 23 +++++++++++------- include/configs/omap3_overo.h | 19 +++++++++----- include/configs/omap3_pandora.h | 19 +++++++++----- include/configs/omap3_sdp3430.h | 38 ++++++++++++++++-------------- include/configs/omap3_zoom1.h | 19 +++++++++----- include/configs/omap3_zoom2.h | 19 +++++++++----- include/configs/tam3517-common.h | 21 ++++++++++------ include/configs/tricorder.h | 23 ++++++++++++------ include/configs/twister.h | 14 +++++++++++ 24 files changed, 315 insertions(+), 154 deletions(-) create mode 100644 include/configs/omap3_common.h
...remove non-beagle patches for brevity...
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 80b9a5a..21e4b01 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -29,16 +29,21 @@ #define __CONFIG_H
/*
- High Level Configuration Options
- Values that differ from platform defaults or are unspecified.
*/ -#define CONFIG_OMAP 1 /* in a TI OMAP core */ -#define CONFIG_OMAP34XX 1 /* which is a 34XX */ -#define CONFIG_OMAP3_BEAGLE 1 /* working with BEAGLE */ +#define CONFIG_SDRC /* The chip has SDRC controller */
-#define CONFIG_SDRC /* The chip has SDRC controller */
I can see it can make sense to have an OMAP/DM/AM3x target without SDRC enabled.
+/* Platform defaults */ +#include <configs/omap3_common.h>
-#include <asm/arch/cpu.h> /* get chip and board defs */ -#include <asm/arch/omap3.h> +/*
- Override the common platform file choices.
- */
+/*
- Other configuration options
- */
+#define CONFIG_OMAP3_BEAGLE /* working with BEAGLE */
/*
- Display CPU and Board information
diff --git a/include/configs/omap3_common.h b/include/configs/omap3_common.h new file mode 100644 index 0000000..417dec0 --- /dev/null +++ b/include/configs/omap3_common.h @@ -0,0 +1,40 @@ +/*
- (C) Copyright 2012
- Texas Instruments Incorporated.
- Tom Rini trini@ti.com
- TI OMAP3 (and AM/DM related parts) common configuration settings
- See file CREDITS for list of people who contributed to this
- project.
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
- */
+#ifndef __CONFIG_OMAP3_COMMON_H +#define __CONFIG_OMAP3_COMMON_H
+/*
- A TI OMAP3 (or similar) core
- */
+#define CONFIG_OMAP +#define CONFIG_OMAP34XX
+/* Get CPU defs */ +#include <asm/arch/cpu.h> +#include <asm/arch/omap3.h>
+#endif /* __CONFIG_OMAP3_COMMON_H */
... non-beagle stuff removed for brevity ...
I think this change looks rather useful and would have no negative impact.