On Wednesday 16 November 2011 16:16:49 Simon Glass wrote:
On Wed, Nov 16, 2011 at 8:03 AM, Mike Frysinger wrote:
On Tuesday 15 November 2011 23:17:06 Simon Glass wrote:
--- a/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c +++ b/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
__u32 datab[4];__u8 *data_buf = (__u8 *) datab;
union {__u32 word[4];__u16 hword[8];__u8 byte[16];} datab;__u8 *data_buf = datab.byte;i thought someone posted this fix to the list before. but maybe it was for a different controller. perhaps this code has been copied/pasted all over ... -mike
Yes I found Marek's patch to another file with the same name, and much of the same code :-( But I don't think we currently have a patch for this file. It issues warnings in about 10 ARM builds from memory.
np. i know much of the u-boot arm tree (like Linux) has crappy cross-SoC integration.
Acked-by: Mike Frysinger vapier@gentoo.org -mike
Well it kinda looks like this OHCI is copy of the drivers/usb/host/ohci-hcd.c ?
M