Hi Simon,
-----Original Message----- From: Simon Glass sjg@chromium.org Sent: Sunday, April 26, 2020 1:16 PM To: Park, Aiden aiden.park@intel.com Cc: Bin Meng bmeng.cn@gmail.com; U-Boot Mailing List <u- boot@lists.denx.de> Subject: Re: [PATCH 0/8] Support 64-bit U-Boot for Slim Bootloader
Hi Aiden,
On Tue, 21 Apr 2020 at 18:45, aiden.park@intel.com wrote:
From: Aiden Park aiden.park@intel.com
This patchset will build 64-bit U-Boot as a Slim Bootloader payload and introduce a new X86_RUN_64BIT_ONLY to build pure 64-bit U-Boot binary without SPL. In addition, this supports 64-bit kernel booting from 64-bit U-Boot.
Aiden Park (8): x86: Add a new X86_RUN_64BIT_ONLY to Kconfig x86: start64: Add a hook at 64-bit entry x86: start64: Support HOB in 64-bit U-Boot x86: slimbootloader: Support 64-bit operation configs: slimbootloader: Add x86_64 slimbootloader config x86: Fix 64-bit compile warning x86: enable 64-bit kernel boot from 64-bit U-Boot doc: slimbootloader: Update 64-bit build instruction
arch/x86/Kconfig | 8 ++++++ arch/x86/cpu/slimbootloader/Makefile | 9 ++++-- arch/x86/cpu/slimbootloader/entry64.S | 14 ++++++++++ arch/x86/cpu/slimbootloader/slimbootloader.c | 17 ++++++++++-- arch/x86/cpu/start64.S | 10 +++++++ arch/x86/cpu/x86_64/Makefile | 2 +- arch/x86/cpu/x86_64/call64.S | 21 ++++++++++++++ arch/x86/cpu/x86_64/cpu.c | 10 +++++++ arch/x86/include/asm/bootparam.h | 10 ++++++- arch/x86/include/asm/zimage.h | 2 +- arch/x86/lib/bootm.c | 10 +++++-- arch/x86/lib/zimage.c | 24 ++++++++++------ cmd/x86/hob.c | 8 +++--- configs/slimbootloader-x86_64_defconfig | 24 ++++++++++++++++ doc/board/intel/slimbootloader.rst | 29 ++++++++++++++++++++ 15 files changed, 176 insertions(+), 22 deletions(-) create mode 100644 arch/x86/cpu/slimbootloader/entry64.S create mode 100644 arch/x86/cpu/x86_64/call64.S create mode 100644 configs/slimbootloader-x86_64_defconfig
For the series:
Tested on qemu: Tested-by: Simon Glass sjg@chromium.org
One little thing that I noticed...your instructions show copying u-boot-dtb.bin into the slimbootloader directory. This is the same as u-boot.bin and I suggest you use that name instead. When I tried to, I got an error.
Thanks for your testing. Let me update the instruction with u-boot.bin.
Regards, Simon
Best Regards, Aiden