Re: [U-Boot-Users] Ocotea board patch

Hi Gerald,

On Wednesday 11 October 2006 03:31, Gerald Jackson wrote:

There is an error in the spd_sdram.c in cpu/ppc4xx/, file in a loop statement that is wrong if you are using two Dimms.

It missing initializing a part of the second dimm. So if you have a 1gig of memory it will show up as 768Megs.

<snip>

--- spd_sdram.OLD 2006-10-10 09:07:34.000000000 -0400 +++ spd_sdram.c 2006-10-10 09:15:08.000000000 -0400 @@ -1733,9 +1733,16 @@ unsigned long program_bxcr(unsigned long cr |= SDRAM_BXCR_SDBE;

	for (i = 0; i < num_banks; i++) {

• 		bank_parms[ctrl_bank_num[dimm_num]+i].bank_size_bytes =
  

• 		if(dimm_num == 1){
  

• 			bank_parms[ctrl_bank_num[dimm_num]+i+1].bank_size_bytes =
  		(4 * 1024 * 1024) * bank_size_id;
  

• 		bank_parms[ctrl_bank_num[dimm_num]+i+1].cr = cr;
  

• 		{
  

• 		else
  

• 		{
  

Hmmm??? "{ else {"??? You mean "} else {", right?

• 			bank_parms[ctrl_bank_num[dimm_num]+i].bank_size_bytes = (4 * 1024 * 1024) * bank_size_id;
  	bank_parms[ctrl_bank_num[dimm_num]+i].cr = cr; 
  

• 		}
  }
  

  } }

Your patch seems broken to me. Did you create it by hand? Please try again.

And please also take make sure that you don't violate the conding style.

Thanks.

Best regards, Stefan