Dear "Jason Hobbs",
In message 20110606205226.GA3035@jhobbs-laptop you wrote:
Dear Wolfgang,
On Mon, Jun 06, 2011 at 09:23:06PM +0200, Wolfgang Denk wrote:
diff --git a/include/common.h b/include/common.h index e659630..fd389e7 100644 --- a/include/common.h +++ b/include/common.h @@ -234,6 +234,7 @@ int readline_into_buffer (const char *const prompt, char * buffer); int parse_line (char *, char *[]); void init_cmd_timeout(void); void reset_cmd_timeout(void); +int _abortboot(int bootdelay);
Why do you make this a reserved identifier? (Quote standard: " All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.").
How about removing static __inline__ from abortboot's definition and calling it directly from code external to main.c, getting rid of the wrapper?
This is probably OK - eventually we should do this only if the PXE code gets included.
Also, if this is needed for the PXE code, it should be part of the PXE patch series.
I submitted two patch series related to PXE today, but they are independent abortboot is needed for the pxecfg code, but not for the DHCP PXE options code.
I understood that when I actually read the other set of patches. Please ignore this comment.
Best regards,
Wolfgang Denk