On Thu, Dec 30, 2021 at 2:12 PM Fabio Estevam festevam@gmail.com wrote:
Hi Peter,
On Thu, Dec 30, 2021 at 11:08 AM Peter Robinson pbrobinson@gmail.com wrote:
That works for my Full board. Interestingly in my playing I had got to similar and had wondered about whether the checkboard function was needed.
One minor query on the above is it worth assigning the board_string return to a local variable rather than called the function twice? Either way feel free to add my RB/TB or let me know if you want me to send a patch. Reviewed-by: Peter Robinson pbrobinson@gmail.com Tested-by: Peter Robinson pbrobinson@gmail.com
Thanks for testing. I can send a formal patch after your series gets applied.
Actually, doing a full boot I get ERROR: invalid device tree Found EFI removable media binary efi/boot/bootarm.efi 1929216 bytes read in 92 ms (20 MiB/s) libfdt fdt_check_header(): FDT_ERR_BADMAGIC
And if I interrupt boot and do printenv I get fdtfile=undefined so while it fixes the detection and printing of the actual model it seems it's too load for the device tree file logic, which now why I remember I was looking at the show_board_info function above, the board_late_init seems to late for the DT logic.
P