-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/07/2013 09:06 PM, Scott Wood wrote:
On Sat, 2013-10-05 at 06:11 +0000, Gupta, Pekon wrote:
Hi, Please see the replies inline..
From: Scott Wood [mailto:scottwood@freescale.com]
On Mon, 2013-09-30 at 19:43 +0530, Pekon Gupta wrote: +Platform specific options +=========================
- CONFIG_NAND_OMAP_ECCSCHEME
- On OMAP platforms, this specifies NAND ECC scheme.
- 1 - HAM1_SW 1-bit Hamming code using software library
(for legacy devices only)- 2 - HAM1_HW 1-bit Hamming code using GPMC hardware engine
(for legacy devices only)- 3 - BCH4_SW 4-bit BCH code (unsupported)
- 4 - BCH4_HW 4-bit BCH code (unsupported)
- 5 - BCH8_SW 8-bit BCH code with
- ecc calculation using GPMC hardware engine,- error detection using software library.- requires CONFIG_BCH to enable software BCHlibrary
(For legacy device which do not have ELM h/wengine)
- 6 - BCH8_HW 8-bit BCH code with
- ecc calculation using GPMC hardware engine,- error detection using ELM hardware engine.You should document the symbols, not the numbers that happen to be assigned to them.
Sorry din't get you. This is based on your below feedback http://lists.denx.de/pipermail/u-boot/2013-September/162773.html
Example: "6 - BCH8_HW" means 8-bit BCH ECC scheme using h/w engine. It is this number is what user needs to specify in include/configs/*.h Any other internal symbol like "OMAP_ECC_BCH8_CODE_SW" should not be exposed to user, user-interface should remain constant.
I disagree. The user should specify OMAP_ECC_BCH8_CODE_SW. It's more greppable, and it's more likely that the number will change than that the name will.
I agree with Scott, enum (if it's not already one) and use the name so it's clear what you're picking.
- -- Tom