On 22:05 Sun 03 May , Wolfgang Denk wrote:
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090503184226.GY25959@game.jcrosoft.org you wrote:
we now switch to console_XX and console_device_t
-----------------------^^^^^^^^^^
Actually there is even a direct name conflict - console_init() is already in use (in board/netphone/phone_console.c), and your patch fails to resolve this conflict.
it does, it's call consoles_init()
Then your comment (see above) and the code disagree.
Maybe "stdio" would be a better choice than "console" here?
why not
Hm... actually checking the code tells that stdio is already taken, too - see show_stdio_dev(), stdio_devices[], stdio_names[].
btw we could stop to export the table
for show_stdio_dev it's just a copy of the common/console.c ligne 604
so we can merge it
But at least thesere are only few identifiers, so this could be delt with.
so no problem
Best Regards, J.