A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Steven Scholz steven.scholz@imc-berlin.de schreibt:
+#ifdef CONFIG_KB920x
- twi->TWI_IADR = addr;
+#else /* Set TWI Internal Address Register with first messages data
field */
/* only one address byte is supported */ if (alen > 0) twi->TWI_IADR = addr & 0xff; +#endif
Why is this required? IMHO we should avoid putting board dependend DEFINES in common code.
kb_admin wrote:
We used the conditional because our board supports more than a single byte for the TWI address and we didn't want to break other targets. Please let me the best solution to this goal as we don't want to use target-specific conditionals, if possible.
The better way would be the fix the at91-i2c driver to support multio byte addresses!
Also, we have updated two constants in the patch. I'm including the original patch modified with the changes.
:-(
gzip isn't exactly human readable! Whcih constants did you change?
-- Steven