-----Original Messages----- From: "Albert ARIBAUD" albert.u.boot@aribaud.net Sent Time: 2014-02-22 00:38:05 (Saturday) To: fenghua@phytium.com.cn Cc: u-boot@lists.denx.de, trini@ti.com Subject: Re: [PATCH] arm64 patch: gicv3 support
Hi fenghua@phytium.com.cn,
On Wed, 15 Jan 2014 16:10:56 +0800, fenghua@phytium.com.cn wrote:
From: David Feng fenghua@phytium.com.cn
This patch add gicv3 support to uboot armv8 platform. Modifications cover 4 source files, as follows: gic.S: gicv3 initialization and sgi interrupt raising. goc.h: gicv3 register definitions. vexpress_aemv8a.h: add CONFIG_GICV2/CONFIG_GICV3 switch. start.S: set SCR_EL3.NS bit to 1, gicv3 register of ICC_SRE_EL2 could be accessed only when SCR_EL3.NS=1. set SCR_EL3.IRQ|FIQ|EA bits, reroute all interrupts to el3 at all cores, slaves could be waken up by interrupt only when the interrupt is routed to it when running at el3. Note: please use the latest gcc 4.8 compiler from linaro which support gicv3 system register assembling.
Signed-off-by: David Feng fenghua@phytium.com.cn
I am not well-versed enough in aarch64 and GIC, be it v2 or v3, so... Is this patch OK as it is, or should a V2 follow with common GIVv2/GICv3 code merged?
Amicalement,
hi Albert, I am preparing the V2, there are some optimizations. But it's still Armv8 specific. I would like to consider common Gicv2/Gicv3 code working across armv7 and armv8. It's not easy and I have no armv7 test environment. Thank you!
Best Regards, David